Repository navigation
Preserve full CA certificate chains - #219
Open
igolaizola wants to merge 1 commit into
Open
igolaizola wants to merge 1 commit into
igolaizola wants to merge 1 commit into
Conversation
Keep every certificate in PEM CA bundles so TLS clients receive the issuer chain. Tests: five chain tests and 28 certificate tests pass.
|
|
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped, preserves signing behavior, and includes regression coverage for both TLS setup paths with no unresolved findings.
No open issues 🎉
What changed in this PR
Preserves full PEM CA bundles when generating certificates so TLS clients receive the complete supplied issuer chain, while retaining the first certificate for signing.
Changes:
- Stores and returns the original CA bundle instead of only its first certificate.
- Adds five regression tests covering chain retention and TLS connections using PEM data or file paths, with and without SNI.
| File | Description |
|---|---|
| test/integration/https-chain.spec.ts | Adds multi-intermediate chain tests across TLS configuration variants. |
| src/util/certificates.ts | Preserves the full CA bundle in generated certificate results. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep every certificate in PEM CA bundles so TLS clients receive the issuer chain.
Tests: five chain tests and 28 certificate tests pass.