Skip to content

fix: redirect-paypro-to-thank-you is called as a POST request#179

Open
gibertoni wants to merge 1 commit into
httptoolkit:mainfrom
gibertoni:fix/pro-thanks-redirect
Open

fix: redirect-paypro-to-thank-you is called as a POST request#179
gibertoni wants to merge 1 commit into
httptoolkit:mainfrom
gibertoni:fix/pro-thanks-redirect

Conversation

@gibertoni
Copy link
Copy Markdown

After I purchased the Pro license, I got the following error in the browser checkout:

Cannot POST /api/redirect-paypro-to-thank-you

It seems like a simple patch since the API is listening to a GET instead of a POST

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Guilherme Gibertoni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks @gibertoni! I've definitely tested this in the past and it has used GET, so I suspect PayPro have multiple flows here for different scenarios, or they've changed something internally. In either case, we should support both GET & POST to handle this. Unfortunately PayPro's docs are terrible so it's not totally clear how this works, but we can support both easily so that's OK. Can you update this to do that?

Please also sign the CLA so this can be merged, it's very short: it just confirms it's your code, you have the rights to contribute it (it's not employer property or similar) and you're happy to give it to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants