Skip to content

Conversation

@q1blue
Copy link

@q1blue q1blue commented Jan 26, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/svelte-vite/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  208  
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  149  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by upgrading specific Storybook-related dependencies. The updates target and resolve two identified medium-severity vulnerabilities, ensuring that the project utilizes more secure versions of these packages. Reviewers should pay close attention to the dependency version changes and the noted requirement for manual yarn.lock updates.

Highlights

  • Dependency Updates: The @storybook/builder-vite dependency has been updated from workspace:* to version 0.1.22, and @storybook/svelte has been updated from workspace:* to version 4.0.0 in code/frameworks/svelte-vite/package.json.
  • Vulnerability Fixes: This pull request addresses two medium-severity vulnerabilities: 'Improper Handling of Unicode Encoding' (SNYK-JS-TAR-15038581) and 'Directory Traversal' (SNYK-JS-TAR-15032660).
  • Yarn Zero-Installs Note: Users leveraging Yarn's zero-installs feature will need to manually run yarn to update the .yarn/cache/ directory, as this PR does not automatically update it.
  • Manual yarn.lock Update Required: The yarn.lock file was not automatically updated by Snyk, requiring a manual update before merging to ensure dependency consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by updating dependencies. However, the proposed change in code/frameworks/svelte-vite/package.json is incorrect. It downgrades @storybook/builder-vite and @storybook/svelte from using the current monorepo workspace versions (workspace:*) to very old, hardcoded versions. This is a critical issue that will likely break the project due to major version mismatches. The change should be reverted, and the vulnerabilities should be addressed by other means, such as using resolutions in the root package.json to pin the transitive dependency (tar) to a secure version.

Comment on lines +50 to +51
"@storybook/builder-vite": "0.1.22",
"@storybook/svelte": "4.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades @storybook/builder-vite and @storybook/svelte to very old versions (0.1.22 and 4.0.0 respectively). The workspace:* protocol ensures that the packages from this monorepo are used, which are currently at version 8.3.0-beta.3. Downgrading to such old versions will almost certainly break the build and the application due to API incompatibilities.

While the intent is to fix security vulnerabilities, this is not the correct approach. The workspace:* protocol should be restored to maintain consistency within the monorepo. The underlying vulnerability in the tar package should be addressed differently, for example by using resolutions in the root package.json to force a secure version of tar across the entire project.

Suggested change
"@storybook/builder-vite": "0.1.22",
"@storybook/svelte": "4.0.0",
"@storybook/builder-vite": "workspace:*",
"@storybook/svelte": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants