Skip to content

Conversation

@q1blue
Copy link

@q1blue q1blue commented Jan 25, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/vue3-webpack5/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  208  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by resolving two critical vulnerabilities. It achieves this by updating specific Storybook dependencies within the vue3-webpack5 framework, ensuring the application benefits from the latest security patches.

Highlights

  • Security Vulnerability Fixes: This PR addresses two medium-severity vulnerabilities: "Improper Handling of Unicode Encoding" (SNYK-JS-TAR-15038581) and "Prototype Pollution" (SNYK-JS-LODASH-15053838).
  • Dependency Upgrades: To resolve the identified vulnerabilities, the @storybook/builder-webpack5 dependency has been upgraded to 7.1.0 and @storybook/vue3 to 6.2.0 in code/frameworks/vue3-webpack5/package.json.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix two security vulnerabilities by updating dependencies. However, the proposed changes are incorrect for this monorepo setup. It replaces workspace-local dependencies (workspace:*) with fixed, older versions from the public registry. This constitutes a major version downgrade for @storybook/builder-webpack5 and @storybook/vue3, which will very likely introduce breaking changes and cause the build to fail. I have left a comment suggesting to revert these changes and instead use Yarn's resolutions feature in the root package.json to address the transitive dependency vulnerabilities without breaking the monorepo structure.

Comment on lines +50 to +52
"@storybook/builder-webpack5": "7.1.0",
"@storybook/preset-vue3-webpack": "workspace:*",
"@storybook/vue3": "workspace:*",
"@storybook/vue3": "6.2.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces workspace-local dependencies (workspace:*) with fixed, older versions from the public registry. This is a critical issue for a few reasons:

  1. Breaks Monorepo Linking: In a Yarn workspace setup, workspace:* ensures that local packages from the monorepo are used. Pinning to a version like 7.1.0 will cause Yarn to fetch the package from the npm registry, ignoring local changes and breaking the integrity of the monorepo.
  2. Major Version Downgrade: The versions in the workspace for @storybook/builder-webpack5 and @storybook/vue3 are 8.3.0-beta.3. Downgrading to 7.1.0 and 6.2.0 respectively are major version downgrades which introduce breaking changes and will almost certainly break the build or cause runtime errors.

To fix the underlying vulnerabilities from lodash and tar correctly, you should revert these changes and consider using Yarn's resolutions feature in the root package.json to force a secure version of these transitive dependencies across the entire workspace.

    "@storybook/builder-webpack5": "workspace:*",
    "@storybook/preset-vue3-webpack": "workspace:*",
    "@storybook/vue3": "workspace:*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants