-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Fix for 2 vulnerabilities #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
…ties The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by resolving two critical vulnerabilities. It achieves this by updating specific Storybook dependencies within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, attempts to fix two security vulnerabilities by updating dependencies. However, the proposed changes are incorrect for this monorepo setup. It replaces workspace-local dependencies (workspace:*) with fixed, older versions from the public registry. This constitutes a major version downgrade for @storybook/builder-webpack5 and @storybook/vue3, which will very likely introduce breaking changes and cause the build to fail. I have left a comment suggesting to revert these changes and instead use Yarn's resolutions feature in the root package.json to address the transitive dependency vulnerabilities without breaking the monorepo structure.
| "@storybook/builder-webpack5": "7.1.0", | ||
| "@storybook/preset-vue3-webpack": "workspace:*", | ||
| "@storybook/vue3": "workspace:*", | ||
| "@storybook/vue3": "6.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change incorrectly replaces workspace-local dependencies (workspace:*) with fixed, older versions from the public registry. This is a critical issue for a few reasons:
- Breaks Monorepo Linking: In a Yarn workspace setup,
workspace:*ensures that local packages from the monorepo are used. Pinning to a version like7.1.0will cause Yarn to fetch the package from the npm registry, ignoring local changes and breaking the integrity of the monorepo. - Major Version Downgrade: The versions in the workspace for
@storybook/builder-webpack5and@storybook/vue3are8.3.0-beta.3. Downgrading to7.1.0and6.2.0respectively are major version downgrades which introduce breaking changes and will almost certainly break the build or cause runtime errors.
To fix the underlying vulnerabilities from lodash and tar correctly, you should revert these changes and consider using Yarn's resolutions feature in the root package.json to force a secure version of these transitive dependencies across the entire workspace.
"@storybook/builder-webpack5": "workspace:*",
"@storybook/preset-vue3-webpack": "workspace:*",
"@storybook/vue3": "workspace:*"
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/vue3-webpack5/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-LODASH-15053838
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution