Skip to content

[Snyk] Security upgrade storybook from 0.0.0-use.local to 0.0.0#340

Open
q1blue wants to merge 1 commit intonextfrom
snyk-fix-2c4c74f751e78fad8594748dd1bacaf4
Open

[Snyk] Security upgrade storybook from 0.0.0-use.local to 0.0.0#340
q1blue wants to merge 1 commit intonextfrom
snyk-fix-2c4c74f751e78fad8594748dd1bacaf4

Conversation

@q1blue
Copy link

@q1blue q1blue commented Jan 24, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/lib/create-storybook/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on enhancing the project's security by updating a key dependency. It aims to mitigate known vulnerabilities in underlying packages by upgrading the storybook dependency, thereby improving the overall security posture of the application. The changes are concentrated on a single package.json file.

Highlights

  • Security Upgrade: The storybook dependency in code/lib/create-storybook/package.json has been upgraded from workspace:* to 0.0.0 to address identified security vulnerabilities.
  • Vulnerability Fixes: This pull request resolves two medium-severity vulnerabilities: a Prototype Pollution issue (SNYK-JS-LODASH-15053838) and a Regular Expression Denial of Service (ReDoS) issue (SNYK-JS-DIFF-14917201).
  • Manual yarn.lock Update Required: The yarn.lock file was not automatically updated by Snyk and requires manual intervention to be brought up to date before merging.
  • Yarn Zero-Installs Guidance: Users leveraging Yarn's zero-installs feature must run yarn locally to update their .yarn/cache/ directory, as this PR does not include those changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix security vulnerabilities by upgrading the storybook dependency. However, the proposed change from "storybook": "workspace:*" to "storybook": "0.0.0" in code/lib/create-storybook/package.json is incorrect. The workspace:* protocol is used in monorepos to link to a local package, and changing it to 0.0.0 will likely break dependency resolution. This change should be reverted. The underlying vulnerabilities should be addressed by updating the project's lockfile.

"prompts": "^2.4.0",
"semver": "^7.3.7",
"storybook": "workspace:*",
"storybook": "0.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The change from workspace:* to 0.0.0 for the storybook dependency is incorrect and will likely break the project. In a monorepo setup, workspace:* is used to reference another package within the same workspace. Replacing it with 0.0.0 attempts to fetch a non-existent or incorrect version from the package registry.

This change should be reverted to keep the correct workspace linking. The security vulnerabilities Snyk is trying to fix should be addressed differently, likely by updating the lockfile (e.g., by running yarn install).

    "storybook": "workspace:*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants