Skip to content

[Snyk] Fix for 4 vulnerabilities #11563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 4 vulnerabilities #11563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/nomad/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "0.1.0",
Comment on lines +27 to +28
Copy link

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning @backstage/core-components and @backstage/core-plugin-api to old, specific versions is incorrect and will likely break the build or cause runtime errors. This project uses a monorepo structure with Yarn workspaces, and dependencies between packages within the monorepo should use workspace:^ to ensure they all use the same, consistent version.

Replacing workspace:^ with hardcoded versions (0.8.6 and 0.1.0) is a significant downgrade from the versions available in this repository (0.13.4-next.0 and 1.5.3 respectively) and will introduce version mismatches and API incompatibilities.

The correct way to fix the underlying security vulnerabilities is to either update the root packages to versions that use non-vulnerable transitive dependencies, or to use the resolutions field in the root package.json to force an upgrade of the specific vulnerable packages (e.g., tar, diff, eslint).

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^"

"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.9.13",
Expand Down
Loading