Skip to content

[Snyk] Fix for 3 vulnerabilities #11562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #11562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/events-backend-module-gerrit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/plugin-events-node": "0.2.9",
Comment on lines +38 to +39
Copy link

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While the intent to fix security vulnerabilities is correct, pinning these dependencies to specific versions breaks the yarn workspace setup of this monorepo. Using workspace:^ ensures that this package uses the local, in-repo versions of @backstage/backend-plugin-api and @backstage/plugin-events-node, which is fundamental for monorepo development and consistency.

Pinning to external versions can lead to:

  • Multiple, conflicting versions of the same package in the project.
  • Local changes in the workspace packages not being reflected during development.
  • Dependency resolution issues, as indicated by the PR note: Failed to update the yarn.lock, please update manually before merging.

The recommended approach is to revert this change and instead address the vulnerabilities by updating the dependencies within the monorepo, which will preserve the integrity of the workspace structure.

Suggested change
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/plugin-events-node": "0.2.9",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",

"winston": "^3.2.1"
},
"devDependencies": {
Expand Down
Loading