Skip to content

[Snyk] Fix for 3 vulnerabilities #11561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #11561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/catalog-backend-module-bitbucket/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-bitbucket-cloud-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-bitbucket-cloud-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +36 to +42
Copy link

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces workspace:^ with pinned versions for several @backstage packages. This is incorrect for a monorepo using Yarn workspaces, as it breaks the mechanism that ensures local packages from the same workspace are used. This can lead to critical issues like dependency mismatches and build failures.

The correct approach is to update the source packages within the workspace to resolve the vulnerabilities.

Additionally, there are two other major concerns with this PR:

  1. The yarn.lock file has not been updated, which is required for dependency changes.
  2. The package being modified, @backstage/plugin-catalog-backend-module-bitbucket, is deprecated. It would be better to migrate away from it rather than applying patches.

Due to these critical issues, these changes should be reverted.

    "@backstage/backend-common": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-bitbucket-cloud-common": "workspace:^",
    "@backstage/plugin-catalog-node": "workspace:^"

"@backstage/types": "workspace:^",
"lodash": "^4.17.21",
"node-fetch": "^2.6.7",
Expand Down
Loading