Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/catalog-backend-module-gitlab/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +48 to +55

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes from workspace:^ to pinned versions are incorrect for this monorepo setup. Using pinned versions instead of the workspace: protocol will break the yarn workspace dependency resolution, causing either build failures or unexpected behavior due to using published package versions from the registry instead of the local workspace packages.

For example:

  • @backstage/catalog-model is being downgraded from a local workspace version (which is 1.4.1) to 0.1.1.
  • @backstage/plugin-catalog-node is being downgraded from a local workspace version (which is 1.4.1-next.0) to 1.0.0.

The correct way to fix the underlying vulnerabilities is to update the vulnerable transitive dependencies within their respective packages in this monorepo (e.g., update tar inside @backstage/backend-common's package.json) and then run yarn to update the yarn.lock file. The workspace:^ references should be kept.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-catalog-node": "workspace:^"

"@backstage/types": "workspace:^",
"lodash": "^4.17.21",
"node-fetch": "^2.6.7",
Expand Down
Loading