forked from SDA-SE/backstage
-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 3 vulnerabilities #11560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
q1blue
wants to merge
1
commit into
master
Choose a base branch
from
snyk-fix-87e7416dceedd42b11864deff0c20fd2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes from
workspace:^to pinned versions are incorrect for this monorepo setup. Using pinned versions instead of theworkspace:protocol will break the yarn workspace dependency resolution, causing either build failures or unexpected behavior due to using published package versions from the registry instead of the local workspace packages.For example:
@backstage/catalog-modelis being downgraded from a local workspace version (which is1.4.1) to0.1.1.@backstage/plugin-catalog-nodeis being downgraded from a local workspace version (which is1.4.1-next.0) to1.0.0.The correct way to fix the underlying vulnerabilities is to update the vulnerable transitive dependencies within their respective packages in this monorepo (e.g., update
tarinside@backstage/backend-common'spackage.json) and then runyarnto update theyarn.lockfile. Theworkspace:^references should be kept.