Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-backend-module-github/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,16 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-backend": "2.0.0",
"@backstage/plugin-catalog-common": "0.1.0",
Comment on lines +48 to +57

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Pinning Backstage dependencies to specific versions breaks the yarn workspace linking in this monorepo. This means local changes in these dependencies (e.g., @backstage/backend-common) will not be picked up by this package during development, which can lead to inconsistencies and hard-to-debug issues.

This change was likely automated by Snyk to fix vulnerabilities, but it doesn't correctly handle monorepo setups. This is also indicated by the PR note: Failed to update the yarn.lock, please update manually before merging.

It's recommended to revert these changes to use workspace:^ and instead perform a proper workspace-wide dependency upgrade to resolve the vulnerabilities.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/catalog-client": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-catalog-backend": "workspace:^",
    "@backstage/plugin-catalog-common": "workspace:^"

"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",
"@backstage/types": "workspace:^",
Expand Down
Loading