Skip to content

[Snyk] Fix for 3 vulnerabilities #11555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #11555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/airbrake-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
Comment on lines +25 to +27
Copy link

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated Snyk PR makes two significant changes to dependencies that need careful review:

  1. @backstage/config downgrade (Critical): The change from "workspace:^" to "0.1.1" is a massive downgrade from the workspace version (likely 1.0.8 or newer). This is almost certainly an error by the Snyk bot and will likely cause build failures or runtime errors due to API incompatibilities with other @backstage packages. This change should be reverted.

  2. Dependency Pinning (Maintainability): Both @backstage/backend-common and @backstage/config are being changed from workspace:^ to pinned versions. This breaks the monorepo's convention of using local workspace packages. While pinning @backstage/backend-common to 0.24.1 might be a valid short-term fix for the tar vulnerability, this approach can create maintenance issues in the long run. The ideal solution would be to update the workspace version of @backstage/backend-common itself.

Given the critical nature of the @backstage/config downgrade, I suggest rejecting that specific change. You should investigate the eslint vulnerability (SNYK-JS-ESLINT-15102420) separately; the fix may lie in updating a devDependency in the root of the repository rather than here.

    "@backstage/backend-common": "0.24.1",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/config": "workspace:^"

"@types/express": "*",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
Expand Down
Loading