Skip to content

[Snyk] Fix for 3 vulnerabilities #11553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #11553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/scaffolder-backend-module-sentry/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^"
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/plugin-scaffolder-node": "0.2.0"
Comment on lines +25 to +27
Copy link

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes are incorrect and will likely break the package. They replace workspace:^ with pinned versions, and in the case of @backstage/config and @backstage/errors, downgrade them to very old versions (e.g., @backstage/config from 1.0.8 to 0.1.1). This breaks the monorepo workspace linking and introduces a high risk of incompatibility issues.

While this is an attempt to fix transitive vulnerabilities, this is not the correct approach. A better way to handle this is to use resolutions in the root package.json to force a secure version of the vulnerable transitive dependencies (like tar or eslint).

I strongly recommend reverting this change and using workspace:^ as it was before. Then, address the vulnerabilities via resolutions.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/plugin-scaffolder-node": "0.2.0"
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^"

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading