Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/org-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
"dependencies": {
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +35 to +38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These automated changes introduce a critical risk by severely downgrading core dependencies. This will likely break the plugin.

  • @backstage/core-components is downgraded from a workspace version (around 0.13.x) to 0.8.6.
  • @backstage/theme is downgraded from a workspace version (around 0.4.x) to 0.1.1.

Such a massive version downgrade will almost certainly introduce breaking API changes and cause the application to fail. Furthermore, removing the workspace:^ protocol breaks the intended monorepo workflow, preventing local development on these packages from being reflected here.

Given these issues and the yarn.lock update failure mentioned in the PR description, this change should be rejected. The underlying vulnerabilities should be investigated and resolved manually, likely at the monorepo root.

Suggested change
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading