Skip to content

[Snyk] Fix for 3 vulnerabilities #11548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #11548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/techdocs-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@
"@aws-sdk/types": "^3.347.0",
"@azure/identity": "^3.2.1",
"@azure/storage-blob": "^12.5.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration-aws-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +49 to +55
Copy link

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The PR description correctly warns that yarn.lock has not been updated. Without the lockfile update, these dependency changes will not be resolved correctly, and the security vulnerabilities will persist. Before merging, please run yarn install (or equivalent) and commit the updated yarn.lock file.

Comment on lines +49 to +55
Copy link

@gemini-code-assist gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Pinning workspace packages like @backstage/backend-common and @backstage/plugin-search-common to specific versions from the registry breaks the monorepo development workflow. This means local changes in those packages will be ignored when working on techdocs-node, which can lead to confusion and bugs.

While this might be a quick way to fix a security issue, it's a workaround. The proper fix is to update the dependency that introduces the vulnerability, while keeping the workspace:^ reference. You can use yarn why <vulnerable-package> to trace the dependency path.

If this is intended as a temporary hotfix, I recommend creating a follow-up ticket to address this properly. For a permanent fix, the workspace: protocol should be restored.

    "@backstage/backend-common": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/integration-aws-node": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^"

"@google-cloud/storage": "^6.0.0",
"@trendyol-js/openstack-swift-sdk": "^0.0.6",
"@types/express": "^4.17.6",
Expand Down
Loading