Skip to content

[Snyk] Fix for 3 vulnerabilities #11546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #11546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/adr-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-adr-common": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-adr-common": "0.1.0",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +31 to +39
Copy link

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While pinning these dependencies to specific versions resolves the security vulnerabilities, it moves away from the workspace:^ protocol used in this monorepo. This can cause maintenance issues and version conflicts in the future.

A more idiomatic fix for a monorepo would be to update the vulnerable transitive dependencies directly in their source packages (e.g., update the tar dependency within the @backstage/backend-common package). After addressing the vulnerabilities at their source, you can revert this change and rely on the workspace mechanism.

If you choose to proceed with pinning as a temporary measure, please remember to run yarn to generate an updated yarn.lock file before merging, as the PR description correctly warns that this step failed.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-client": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-adr-common": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^"

"@types/express": "^4.17.6",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
Expand Down
Loading