Skip to content

[Snyk] Fix for 6 vulnerabilities #11224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #11224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/catalog-backend-module-unprocessed/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
"dist"
],
"dependencies": {
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/plugin-auth-node": "0.6.0",
Comment on lines +31 to +33
Copy link

@gemini-code-assist gemini-code-assist bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes, which replace workspace:^ with pinned versions, are incorrect for this monorepo setup and will likely break the project. The workspace: protocol is intentionally used in monorepos to ensure that internal packages use the versions from the local workspace, providing consistency and avoiding version conflicts.

By pinning to specific versions:

  • You lose the benefit of the monorepo's single version policy.
  • It can introduce multiple, conflicting versions of the same package.
  • In this case, it's attempting to downgrade @backstage/catalog-model from version 1.4.1 (in the workspace) to 0.1.1, which is a significant and breaking downgrade.

The correct approach to fix the underlying vulnerabilities is to update the dependencies within the monorepo itself, not to pin versions in consuming packages. These changes should be reverted.

    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^"

"express-promise-router": "^4.1.1",
"knex": "^2.4.2"
}
Expand Down
Loading