Skip to content

fix: defer help_formatter to prevent eager getter in Python 3.14+ (#1641) #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fazalpsinfo-cmyk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: defer help_formatter to prevent eager getter in Python 3.14+ (#1641) #1902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion httpie/cli/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,18 @@ def __init__(
**kwargs
) -> None:
self.getter = getter
self.help_formatter = help_formatter
self.sort = sort
self.cache = cache
self.isolation_mode = isolation_mode
self._help: Optional[str] = None
self._obj: Optional[Iterable[T]] = None
# Defer setting help_formatter until after super().__init__()
# to prevent argparse._check_help (Python 3.14+) from triggering
# the lazy getter during argument registration.
deferred_formatter = help_formatter
self.help_formatter = None
super().__init__(*args, **kwargs)
self.help_formatter = deferred_formatter
self.choices = self

def load(self) -> T:
Expand Down
Loading