fix: LazyChoices compatibility with Python 3.14+ (#1641)#1901
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
fix: LazyChoices compatibility with Python 3.14+ (#1641)#1901fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
Python 3.14+ argparse validates default against choices at registration time. LazyChoices set self.choices = self, which triggered eager getter calls during parser construction, causing test_lazy_choices_help to fail. Fix: removed self.choices = self from __init__, added manual choice validation in __call__ raising ArgumentError when value isn't in loaded choices. Fixes httpie#1641
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: LazyChoices fails on Python 3.14
Python 3.14+ argparse validates
defaultagainstchoicesat registration time.LazyChoicessetself.choices = self, which triggered eager getter calls duringparser construction, causing
test_lazy_choices_helpto fail.Fix
self.choices = selffrom__init____call__— raisesArgumentErrorif thevalue isn't in the loaded choices at parse time
The getter remains fully lazy: it is only called when
--helpor when a valueis actually parsed. Verified: 3 checks pass.
Fixes #1641
Support my work: If this fix helped, consider buying me a coffee at https://buymeacoffee.com/muhamedfazalps ☕