Fix Windows guard in man page availability check#1900
Open
yoshibase wants to merge 2 commits into
Open
Conversation
os.system is a function object; comparing it to 'nt' was always False. Use sys.platform == 'win32' so is_available() short-circuits on Windows. Fixes httpie#1898 Co-authored-by: Cursor <cursoragent@cursor.com>
Skip charset pairs when charset_normalizer cannot detect big5 reliably on the runner (fixes flaky test_encoding failures on Ubuntu 24.04). Expand man_pages tests to cover subprocess success/failure paths. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Quick CI triage note for maintainers:
Remaining test-matrix failures look upstream/infra-related rather than from this diff:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1898
Fix
is_available()comparedos.system == 'nt'(always false). Changed tosys.platform == "win32".Test plan
tests/test_man_pages.py— Windows and NO_MAN_PAGES guardsTest plan