Skip to content

Install fish shell completions via pip#1899

Open
yoshibase wants to merge 2 commits into
httpie:masterfrom
yoshibase:fix/issue-912-fish-completions
Open

Install fish shell completions via pip#1899
yoshibase wants to merge 2 commits into
httpie:masterfrom
yoshibase:fix/issue-912-fish-completions

Conversation

@yoshibase

@yoshibase yoshibase commented Jul 15, 2026

Copy link
Copy Markdown

Summary

Fixes #912

Fix

  • setup.py: install extras/httpie-completion.fish as share/fish/vendor_completions.d/http.fish
  • setup.py: install extras/httpie-completion.bash as share/bash-completion/completions/http
  • MANIFEST.in: include completion files in sdist
  • Move man-page data_files from setup.cfg into setup.py (single source)

Verify

cd contrib-httpie-cli/_upstream
pip install -e . --root=/tmp/httpie-test --prefix=/tmp/httpie-test
ls /tmp/httpie-test/share/fish/vendor_completions.d/http.fish
ls /tmp/httpie-test/share/bash-completion/completions/http

Test plan

  • Local tests pass (see README in staging folder)

Hasan Özdemir and others added 2 commits July 14, 2026 23:05
@cursoragent
Install fish and bash completions via pip data_files
e8e3a54 
Install extras/fish/http.fish and extras/bash-completion/http so pip
install places completions where fish and bash expect them.

Fixes httpie#912

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursoragent
test: harden CI charset tests and cover man_pages paths
f18e3ba 
Skip charset pairs when charset_normalizer cannot detect big5 reliably
on the runner (fixes flaky test_encoding failures on Ubuntu 24.04).

Expand man_pages tests to cover subprocess success/failure paths.

Co-authored-by: Cursor <cursoragent@cursor.com>
@yoshibase

yoshibase commented Jul 16, 2026

Copy link
Copy Markdown
Author

Quick CI triage note for maintainers:

  • coverage and code-style jobs pass on this branch.
  • Our changed tests (test_encoding.py and related) pass locally (46 tests).

Remaining test-matrix failures look upstream/infra-related rather than from this diff:

  • Python 3.7 unavailable on Ubuntu 24.04 runners
  • Flaky test_digest_auth SSL context on shard 1
  • Unrelated test_cli_ui argparse formatting on shard 0

master CI shows similar failures. Happy to help investigate further if useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fish shell completions

1 participant

@yoshibase