[codex] Reject unsupported StyleX declarations - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make unsupported StyleX declarations fail compilation instead of silently disappearing. Product browser comparisons found missing borders even though the source had typechecked: the pinned StyleX 0.19 property-specificity expander defaults to silent validation and drops unsupported shorthand rules.
The public compiler and package transform now select the supported
propertyValidationMode: "throw"option. The canonical compiler identity binds that policy; old silent-validation manifests cannot pass by recalculating their own hashes. Mapped and unmapped transforms share the same option. Supported longhands, conditional declarations, and supported font shorthands retain their behavior.This prepares v0.5.12. Generated build tools and the manifest were refreshed. Runtime JavaScript and standalone CSS remain byte-identical, including all 701 canonical rules. Existing immutable releases are untouched. Design-kit and footer manifests must be rebuilt against the new compiler before products adopt fresh graph generations; this PR does not claim those downstream upgrades are complete.
Evidence and remaining work
54b38a82cdad2f8991f0231e0b14af54a83509ed(tree3c1ca9e0951aa90378ecb4123f8cf255bfc129c7): 693 tests, 0 failures, 32,077 assertions across 57 files; package, deterministic artifacts, Vite 7/8 production/source-map matrices, Next 16.2.12/16.3.3, packed Bun, and the full primitive browser gallery all passed. Chrome for Testing 151.0.7922.34 was used. Scheduler ownership returned with a clean tracked/untracked worktree and no matching gate survivor.The base is the reviewed UI v0.5.11 release commit. Keep the unrelated Next development PRs #58/#59 and dependency PR #61 separate.