Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6544.
OneCycleLR captures optional arguments in kwargs but did not forward them to PyTorch. The documented three_phase=True option therefore silently used the two-phase curve, changing both learning rates and cycled momentum. total_steps=None with epochs and steps_per_epoch also failed to construct the documented inferred-length schedule.
Forward the optional arguments to the native scheduler. Explicit wrapper arguments and the maximum learning rates taken from optimizer groups remain unchanged. Unknown optional arguments now receive the native constructor's validation.
Validation
python -m pytest tests/test_optimizer/test_onecycle_options.py tests/test_optimizer/test_lr_scheduler.py -q: 16 passed, including the existing scheduler save/load regression.git diff --checkpassed.