Skip to content

fix: add path validation in profiling_utils.py... #6430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

fix: add path validation in profiling_utils.py... #6430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions applications/ColossalChat/coati/distributed/profiling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@ class CustomProfiler:
def __init__(self, name, disabled=True):
self.disabled = disabled
if not disabled:
self.name = name
safe_name = os.path.basename(name)
if not safe_name or os.sep in safe_name or (os.altsep and os.altsep in safe_name):
raise ValueError(f"Invalid profiler name: {name!r}")
self.name = safe_name
self.pid = os.getpid()
self.file = open(f"{name}.prof", "w")
self.file = open(os.path.join(".", self.name + ".prof"), "w")

def _log(self, message):
if self.disabled:
Expand Down