Skip to content

fix(triton): uncross Q/K halves in fused_rotary_emb #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Solaris-star wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

fix(triton): uncross Q/K halves in fused_rotary_emb #6429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions colossalai/kernel/triton/fused_rotary_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def fused_rotary_emb(
+ dim_range0[None, None, :] * head_dim_stride
)
off_k1 = (
idx * q_token_stride
idx * k_token_stride
+ cur_head_range[None, :, None] * k_head_stride
+ dim_range1[None, None, :] * head_dim_stride
)
Expand Down Expand Up @@ -88,10 +88,12 @@ def fused_rotary_emb(
other=0.0,
)

# Standard rotary: [x0, x1] -> [x0*cos - x1*sin, x0*sin + x1*cos]
# Previous code cross-wired Q/K for out_q1 and out_k0 (see #6428).
out_q0 = q_0 * cos - q_1 * sin
out_q1 = k_0 * sin + k_1 * cos
out_q1 = q_0 * sin + q_1 * cos

out_k0 = q_0 * cos - q_1 * sin
out_k0 = k_0 * cos - k_1 * sin
out_k1 = k_0 * sin + k_1 * cos
# concat
tl.store(
Expand Down