Skip to content

feat(linter): align Super-Linter defaults with workflow behavior - #597

Merged
neilime merged 1 commit into
mainfrom
copilot/improve-linter-configuration
Sep 1, 2026
Merged

feat(linter): align Super-Linter defaults with workflow behavior#597
neilime merged 1 commit into
mainfrom
copilot/improve-linter-configuration

Conversation

Copilot AI commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

The reusable linter workflow now produces Super-Linter summaries without warnings while keeping commit message validation enabled for repositories that do not provide their own commitlint configuration.

What changed

Summary handling

  • Default SAVE_SUPER_LINTER_SUMMARY to true so the configured GitHub step summary and pull request summary paths are consistent with Super-Linter's requirements.
  • Preserve caller overrides supplied through linter-env.

Opinionated commitlint fallback

  • Keep Super-Linter's commitlint validator enabled by default.
  • Detect commitlint configuration in supported .commitlintrc* and commitlint.config.* files, or in the root package.json.
  • Generate a temporary commitlint.config.cjs with the repository's Conventional Commits rules only when commitlint is enabled and no caller configuration exists.
  • Preserve an explicit VALIDATE_GIT_COMMITLINT=false override.
  • Normalize an explicit VALIDATE_GIT_COMMITLINT=true back to Super-Linter's enabled-by-default behavior, avoiding its unsupported mix of include and exclude validator flags.
  • Return the generated configuration's absolute path as a step output and remove that exact file after Super-Linter finishes, including on failure.

Workflow structure

  • Separate Super-Linter environment configuration, commitlint fallback configuration, and Prettier plugin discovery into focused sequential steps.
  • Keep the existing conditional Node.js setup for repositories that declare Prettier plugins.

Validation

  • make lint

@neilime neilime left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Comment thread .github/workflows/linter.yml Outdated

Copilot AI commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@copilot handle feedbacks

Addressed in 1bbd99a: commitlint is enabled again, the workflow now writes an opinionated fallback config when none exists, and the generated file is cleaned up afterward.

Copilot AI requested a review from neilime August 31, 2026 05:48
@neilime neilime changed the title Align Super-Linter defaults with workflow behavior feat(linter): align Super-Linter defaults with workflow behavior Aug 31, 2026
@neilime
neilime marked this pull request as ready for review August 31, 2026 06:48

@neilime neilime left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot now the job is failing:

Super-Linter initialization
2026-08-31 06:50:03 [ERROR] Behavior not supported, please either only include (VALIDATE=true) or exclude (VALIDATE=false) linters, but not both
2026-08-31 06:50:03 [FATAL] Error while validating the configuration of enabled linters

Fix that

Copilot AI commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@copilot now the job is failing:

Super-Linter initialization...

Fixed in 076ec3c. The workflow no longer exports a conflicting VALIDATE_GIT_COMMITLINT=true flag, so Super-Linter keeps its default commitlint behavior without tripping the include/exclude validator conflict.

Copilot AI requested a review from neilime August 31, 2026 07:00
@github-actions

Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
BIOME_FORMAT Pass ✅
BIOME_LINT Pass ✅
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_COMMITLINT Fail ❌
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

Super-linter detected linting errors

For more information, see the GitHub Actions workflow run

Powered by Super-linter

GIT_COMMITLINT
�[90m⧗�[39m   input: �[1mrefactor: clarify commitlint disable check

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>�[22m
�[1m�[32m✔�[39m   found 0 problems, 0 warnings�[22m
�[90m⧗�[39m   input: �[1mrefactor: clarify commitlint enablement guard

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>�[22m
�[1m�[32m✔�[39m   found 0 problems, 0 warnings�[22m
�[90m⧗�[39m   input: �[1mfix: avoid conflicting commitlint validator flag

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>�[22m
�[1m�[32m✔�[39m   found 0 problems, 0 warnings�[22m
�[90m⧗�[39m   input: �[1mfix: use absolute cleanup path for generated commitlint config

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>�[22m
�[1m�[32m✔�[39m   found 0 problems, 0 warnings�[22m
�[90m⧗�[39m   input: �[1mfix: always clean generated commitlint config

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>�[22m
�[1m�[32m✔�[39m   found 0 problems, 0 warnings�[22m
�[90m⧗�[39m   input: �[1mfix: clean up generated commitlint config

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>�[22m
�[1m�[32m✔�[39m   found 0 problems, 0 warnings�[22m
�[90m⧗�[39m   input: �[1mfix: harden generated commitlint fallback

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>�[22m
�[1m�[32m✔�[39m   found 0 problems, 0 warnings�[22m
�[90m⧗�[39m   input: �[1mfix: add default commitlint configuration

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>�[22m
�[1m�[32m✔�[39m   found 0 problems, 0 warnings�[22m
�[90m⧗�[39m   input: �[1mSet safer Super-Linter defaults

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>�[22m
�[31m✖�[39m   subject may not be empty �[90m[subject-empty]�[39m
�[31m✖�[39m   type may not be empty �[90m[type-empty]�[39m

�[1m�[31m✖�[39m   found 2 problems, 0 warnings�[22m
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@neilime
neilime force-pushed the copilot/improve-linter-configuration branch from 076ec3c to 9628d3e Compare August 31, 2026 07:23
@github-actions

Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
BIOME_FORMAT Pass ✅
BIOME_LINT Pass ✅
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_COMMITLINT Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@neilime
neilime force-pushed the copilot/improve-linter-configuration branch 2 times, most recently from 5177231 to 8c5243a Compare September 1, 2026 08:44
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
BIOME_FORMAT Pass ✅
BIOME_LINT Pass ✅
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Fail ❌
GITLEAKS Pass ✅
GIT_COMMITLINT Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

Super-linter detected linting errors

For more information, see the GitHub Actions workflow run

Powered by Super-linter

GITHUB_ACTIONS_ZIZMOR
🌈 zizmor v1.23.1
�[33m WARN�[0m �[1mcollect_inputs�[0m�[2m:�[0m �[2mzizmor::registry::input�[0m�[2m:�[0m failed to validate input as workflow: input does not match expected validation schema
�[1m�[31mfatal�[39m�[0m: no audit was performed
�[1m�[91merror�[0m�[1m: no inputs collected�[0m
  �[1m�[94m|�[0m
  �[1m�[94m= �[0m�[1mhelp�[0m: collection yielded no auditable inputs
  �[1m�[94m= �[0m�[1mhelp�[0m: inputs must contain at least one valid workflow, action, or Dependabot config

Caused by:
    no inputs collected

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
@neilime
neilime force-pushed the copilot/improve-linter-configuration branch from 8c5243a to d0af3f3 Compare September 1, 2026 09:21
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
BIOME_FORMAT Pass ✅
BIOME_LINT Pass ✅
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_COMMITLINT Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@neilime
neilime merged commit efc2024 into main Sep 1, 2026
43 checks passed
@neilime
neilime deleted the copilot/improve-linter-configuration branch September 1, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants