fix(core): honor FILTERTYPE_INCOMPLETETASKS in task sync#172
Merged
Conversation
When the client selects FilterType 8 (incomplete tasks only), list incomplete tasks on initial sync, soft-delete completed tasks on modify, and refresh completed items when the filter changes. Depends on horde/activesync passing filtertype to getServerChanges() and horde/nag listUids/isComplete API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Clients can request incomplete-only task sync, but the driver listed all tasks and ignored the filter.
Changes
lib/Horde/Core/ActiveSync/Driver.php: filter initial/incremental task changes; handle filter refreshlib/Horde/Core/ActiveSync/Connector.php: pass completed filter to Nag; addtasks_isComplete()Dependencies
listUids($completed)andisComplete()$filtertypeas 9th argument togetServerChanges()Test plan
Merge order
Merge after horde/nag and horde/activesync PRs land.
Made with Cursor