Implement attendee counter-proposal storage#168
Merged
Conversation
Add functionality to store attendee counter-proposals in the calendar.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds server-side persistence of EAS 16.1 attendee counter-proposals during MeetingResponse handling, by calling into Kronolith’s calendar API so proposed times can be re-synced to devices and later cleared when declined.
Changes:
- In
meetingResponse(), storeProposedStartTime/ProposedEndTimeon the calendar event viacalendar/storeAttendeeProposal. - On storage failure, log a warning and continue with the existing reply/COUNTER email flow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| if (!empty($proposedStart)) { | ||
| try { | ||
| $this->_registry->call('calendar/storeAttendeeProposal', [ |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ralflang
added a commit
that referenced
this pull request
Jun 24, 2026
Release version 3.0.0-RC10 fix: Ensure absolute URLs from registry are used correctly in withAppWebroot & friends fix(core): popup CSRF without SID in URL query fix(core): add CSRF token to HordePopup.popup at click time fix(core): honor FILTERTYPE_INCOMPLETETASKS in task sync fix(core): honor FILTERTYPE_INCOMPLETETASKS in task sync feat(core): pass ActiveSync sync config to driver feat(core): pass ActiveSync sync config to driver Merge pull request #168 from horde/feat/polish_EAS16.1 Potential fix for pull request finding Merge pull request #169 from horde/fix/portal-layout-csrf-token refactor(core): inject session for portal layout CSRF check Add meeting response proposal tests fix(core): validate portal layout CSRF with session checkToken Implement attendee counter-proposal storage Merge pull request #167 from horde/fix/redbox-autocompleter-dialog-reopen Delete doc/pr directory fix(core): harden RedBox and autocompleter dialog DOM handling fix(activesync): honor per-user EAS 16.1 permission in versionCallback feat(core): add EAS 16.1 meeting proposal handling in MeetingResponse fix(session): guard session_destroy() when no active PHP session Merge pull request #164 from horde/fix/map_OSM Update js/map/osm.js Update js/map/ocm.js Update js/map/owm.js Merge pull request #163 from horde/feat/finish_EAS16.0 fix(maps): allow OSM tile Referer and use HTTPS tile URLs feat(activesync): EAS 16.0 draft sync and calendar initial-sync in core driver refactor: shrink base factory class to accept "Injector" (of which Horde_Injector is a duck type)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MeetingResponsecommands onto the Kronolith calendar viacalendar/storeAttendeeProposal.Motivation
When an iOS client proposes a new meeting time, Horde already parses
ProposedStartTime/ProposedEndTime, validates disallow-counter flags, and sendsMETHOD=COUNTERmail to the organizer. Without storing the proposal on the server-side calendar event, Kronolith cannot:This change closes the inbound path: device → server storage → sync / clear on decline.
Changes
lib/Horde/Core/ActiveSync/Driver.phpIn
_meetingResponse(), after proposal validation and before sending COUNTER iTip mail:calendar/storeAttendeeProposalwith event UID, attendee email, and proposed start/end.test/Unit/ActiveSync/DriverMeetingResponseTest.phpAdd targeted unit coverage for attendee proposal persistence in
meetingResponse():ProposedStartTimeandProposedEndTimeare presentDependencies
Requires horde/kronolith (
storeAttendeeProposaland related counter-proposal APIs). Works together with horde/activesync (WBXML export/clear) and horde/imp (organizer accept/decline in webmail).Test plan
ProposedStartTime/ProposedEndTimefor attendeemeetingResponse()proposal storage and skip paths