ci: allow the acceptance suite to be run on demand - #416
Merged
Merged
Conversation
The pull_request trigger does not fire when a PR's head branch is updated by merging another PR into it. Merging #392 into the v2.6.0 release branch moved it 20 commits and 75 files, and produced no acceptance run at all -- so the code about to ship had never been through the gate it is judged by. There was no way to force one: this workflow had no manual trigger, and re-running an existing run re-runs the commit it was created for, which says nothing about the new code. workflow_dispatch closes that. Note GitHub reads the workflow definition from the ref being dispatched, so a branch can only be dispatched once it also carries this block -- merging it to main is necessary but not sufficient for an existing release branch. Related: #395 (CI does not run on PRs that target a branch other than main). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BnrKWZQASV7bFJ4oGWwmo9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
workflow_dispatchto the Acceptance Tests workflow so the suite can be run against a branch on demand.Why
Merging #392 into the v2.6.0 release branch moved it 20 commits and 75 files — and triggered no acceptance run at all. GitHub's
pull_requesttrigger does not fire when a PR's head branch is updated by merging another PR into it, so #378 sat at its new head with a single skipped check.There was no way to force one. This workflow had no manual trigger, and
gh run rerunre-runs the commit its run was created for — which tells you nothing about the new code.So the code about to ship had never been through the gate it is judged by, and there was no lever to fix that.
Caveat worth knowing
GitHub reads the workflow definition from the ref being dispatched. Merging this to
mainis therefore necessary but not sufficient to dispatch an existing release branch — that branch also has to carry this block, e.g. by mergingmaininto it.Scope
One trigger added. No job, step, secret or permission changes. The
pull_requesttrigger is untouched, so nothing about existing PR behaviour changes.Related
main. Same root cause: the release workflow relies on triggers that a stacked-branch workflow never produces.🤖 Generated with Claude Code
https://claude.ai/code/session_01BnrKWZQASV7bFJ4oGWwmo9