Repository navigation
fix(listener): do not send a complete response when the body fails during the early read - #414
Open
sarankumar1325 wants to merge 1 commit into
Open
sarankumar1325 wants to merge 1 commit into
sarankumar1325 wants to merge 1 commit into
Conversation
…ring the early read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #413
When a handler returns a native
Response(for example withoverrideGlobalObjects: false) whose body errors during the early read inresponseViaResponseObject, the error was logged and treated as the end of the body. The listener then setContent-Lengthto whatever had been read so far and ended the response, so the client got a complete200with an empty body (or a truncated one, if a chunk had been read before the error).Now an error from the early read is passed to
handleResponseError, the same handler the streaming paths use. Since no head has been sent yet, the client gets a500instead of a complete success.Tests
Two new cases in
test/listener.test.ts, using a nativeResponse:Both fail on
main(status200) and pass with this change.vitest run(505 tests),eslint src test,tsc --noEmitandprettier --checkall pass.I used an AI assistant to help write this change and checked the result myself.