Skip to content

minor testscripts improvement#244

Merged
hoene merged 2 commits intomainfrom
improvement/testscripts
Mar 29, 2026
Merged

minor testscripts improvement#244
hoene merged 2 commits intomainfrom
improvement/testscripts

Conversation

@umlaeute
Copy link
Copy Markdown
Collaborator

@umlaeute umlaeute commented Feb 2, 2026

  • use the same interface for all test wrappers (tests/*.sh): <scriptname> <testfile-without-extension> [<mysofa2json>]

  • improve argument check, and print usage information if the test-scripts are called with the wrong args

  • consistent indentation and removed trailing whitespace

  • pass the path to mysofa2json to the tests/nocrash.sh script as well (like for the other wrappers)

  • Related: v1.3.4 test suite fails #243

also:
- use named variables
- more (and modernized) quoting
- strip trailing whitespace
- consistent indentation
@umlaeute
Copy link
Copy Markdown
Collaborator Author

umlaeute commented Feb 2, 2026

some more ideas for improving the test-scripts:

  • should usage errors always return 128? (currently, if my new argument checks fail, it will simply return 1)
  • should we use named options for passing the mysofa2json path? e.g.
    -tests/compare.sh tests/MIT_KEMAR_large_pinna path/to/mysofa2json
    +tests/compare.sh -m path/to/mysofa2json tests/MIT_KEMAR_large_pinna
    this appears to be more extendible (what if we ever want to pass more arguments)

i can implement both if you want me to.

Copy link
Copy Markdown
Owner

@hoene hoene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thansk!

@hoene hoene merged commit 302b3fd into main Mar 29, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants