Skip to content

Fix all Scala warnings in HKMC2#503

Merged
LPTK merged 16 commits into
hkust-taco:hkmc2from
Derppening:misc/fix-scala-warnings
Jun 5, 2026
Merged

Fix all Scala warnings in HKMC2#503
LPTK merged 16 commits into
hkust-taco:hkmc2from
Derppening:misc/fix-scala-warnings

Conversation

@Derppening
Copy link
Copy Markdown
Contributor

Most warnings are mechanically addressable by either using alternative paradigms or removing redundant code.

The parts of this PR which require more scrutiny are:

  • 90d09f5: Adding @unchecked to match arms, which may require more scrutiny since these will not be caught at runtime
  • ab1ea34: Implement missing match arms by either (a) adding the appropriate logic (e.g. in showPlain), (b) adding a TODO(...), or (c) adding a lastWords or equivalent - Whether my additions are appropriate needs to be looked into.

Most difftests are unchanged - Some MatchErrors are changed into actual compilation errors.

@Derppening Derppening requested a review from LPTK May 27, 2026 06:33
Comment thread hkmc2/shared/src/main/scala/hkmc2/codegen/Block.scala Outdated
@Derppening Derppening marked this pull request as ready for review June 1, 2026 06:23
@Derppening
Copy link
Copy Markdown
Contributor Author

I think this PR should be ready for review. All warnings have been addressed.

Copy link
Copy Markdown
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@LPTK LPTK merged commit 2af0fe4 into hkust-taco:hkmc2 Jun 5, 2026
1 check passed
@LPTK LPTK deleted the misc/fix-scala-warnings branch June 5, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants