[#433] SimpleToString with dep-free execution#446
Open
laurentschoelens wants to merge 2 commits intohighsource:masterfrom
Open
[#433] SimpleToString with dep-free execution#446laurentschoelens wants to merge 2 commits intohighsource:masterfrom
laurentschoelens wants to merge 2 commits intohighsource:masterfrom
Conversation
mattrpav
requested changes
Oct 20, 2023
Collaborator
mattrpav
left a comment
mattrpav
left a comment
There was a problem hiding this comment.
For the test data, we should validate against the range for all types.
For example for long: null, min, max and zero values
<xs:element name="longMin" type="xs:long" minOccurs="0">
<xs:element name="longMax" type="xs:long" minOccurs="0">
<xs:element name="longNull" type="xs:long" minOccurs="0">
<xs:element name="longZero" type="xs:long" minOccurs="0">
|
|
||
| final Object object = createContext().createUnmarshaller().unmarshal(sample); | ||
| if (object instanceof JAXBElement) { | ||
| System.out.println(((JAXBElement<?>) object).getValue().toString()); |
Collaborator
There was a problem hiding this comment.
We should compare with the expected String output here
Collaborator
There was a problem hiding this comment.
@laurentschoelens will you have some time to look at updating the test check? I think this is a good change to get into next v4.x release!
Collaborator
Author
There was a problem hiding this comment.
I need to do rework here before merging this. If I can, it'll be a GO for 4.0.1, or at least a reduced version of it (removing the way we format java.util.Date and java.time classes)
Collaborator
There was a problem hiding this comment.
Have you had time to look into this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #433
Adds a SimpleToString plugin with customizations