fix(cli): snapshot picks the frame through a rate lane and up to 10x - #4170
Closed
miguel-heygen wants to merge 1 commit into
Closed
miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
…to 10x hyperframes snapshot clamped the constant playback rate at 5 and ignored a rate lane in data-automation, so a sped-up or ramped clip showed the wrong frame. It now reads the rate through the runtime's own reader and maps time with the shared source-time function.
This was referenced Sep 19, 2026
Collaborator
Author
|
Folded into #4153 (one speed-ramp feature, one PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
hyperframes snapshotpicks the source frame for each video clip. It clamped a clip's constant playback rate at 5 and ignored a speed-rampratelane, so a clip at 8x, or one with a ramp, showed the wrong frame in a snapshot while the preview and the render were right.It now reads the rate through the runtime's own reader (a
ratelane wins, thendata-playback-rateclamped 0.1 to 10, then the browser default) and maps time with the sharedsourceTimeAt/timeAtSourceTime.Verification
snapshot.test.ts: 38 passed on the devbox (exit 0). New tests cover rate 8, an invalid authored rate falling back to the browser default, and a rate lane mapping 2 s of clip to 3.641 s of source.tsc --noEmitinpackages/cli: exit 0.snapshot.ts, duration and loop arithmeticreadElementRateSpecclampdefaultPlaybackRate != 1, startup time of the core import