Skip to content

test(cli): lint registry components one test per item #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miguel-heygen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(cli): lint registry components one test per item #4126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 13 additions & 20 deletions packages/cli/src/registry/registryComponents.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,26 +44,19 @@ async function invalidDemoMedia(entryName: string): Promise<string[]> {
.map((finding) => `${entryName}/demo.html: ${finding.code}`);
}

describe("registry components", () => {
it("ships installable snippets without invalid nested media", async () => {
const invalidMedia: string[] = [];

for (const entry of readdirSync(componentsDir, { withFileTypes: true })) {
if (!entry.isDirectory()) continue;
invalidMedia.push(...(await invalidInstallableMedia(entry.name)));
}

expect(invalidMedia).toEqual([]);
});
const entryNames = readdirSync(componentsDir, { withFileTypes: true })
.filter((entry) => entry.isDirectory())
.map((entry) => entry.name);

it("ships demos without source-less media", async () => {
const invalidMedia: string[] = [];

for (const entry of readdirSync(componentsDir, { withFileTypes: true })) {
if (!entry.isDirectory()) continue;
invalidMedia.push(...(await invalidDemoMedia(entry.name)));
}

expect(invalidMedia).toEqual([]);
describe("registry components", () => {
it.each(entryNames)(
"%s ships installable snippets without invalid nested media",
async (name) => {
expect(await invalidInstallableMedia(name)).toEqual([]);
},
);

it.each(entryNames)("%s ships a demo without source-less media", async (name) => {
expect(await invalidDemoMedia(name)).toEqual([]);
});
});
Loading