Skip to content

chore(studio): document CSS-path position cut-over; GSAP-path deferred (§3.3) #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanceingalls wants to merge 1 commit into
base: 06-15-feat_studio_route_timeline_trim_move_through_sdk_settiming_3.2_
Choose a base branch
from
+4 −0
Open

chore(studio): document CSS-path position cut-over; GSAP-path deferred (§3.3) #1467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/studio/src/hooks/useDomGeometryCommits.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ export function useDomGeometryCommits({
}: UseDomGeometryCommitsParams) {
const handleDomPathOffsetCommit = useCallback(
(selection: DomEditSelection, next: { x: number; y: number }) => {
// ponytail: GSAP-targeted elements are blocked (no SDK position-in-script op); CSS-path
// elements fall through to commitPositionPatchToHtml → persistDomEditOperations →
// onTrySdkPersist and are already SDK-cut-over as setStyle/setAttribute (§3.3 done).
// Upgrade path for GSAP: add a moveElementGsap SDK op in a separate SDK PR.
if (isElementGsapTargeted(previewIframeRef.current, selection.element)) {
const error = new Error(GSAP_CSS_FALLBACK_BLOCKED_MESSAGE);
showToast(error.message, "error");
Expand Down
Loading