Remove hackney dependency#147
Open
ericmj wants to merge 4 commits into
Open
Conversation
Add Preview.HTTP.post/4, rewrite Fastly.post/2 to use it with binary-keyed headers, rename read_body/1 to decode_body/1 (no longer needs to call :hackney.body/1), and add error clause to handle retries exhausted. Add bypass dep and a Bypass test for HTTP.post/4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the remaining
:hackneycalls inPreview.CDN.Fastlywith Finch, explicitly configure ex_aws (Req) and Sentry (Finch) so the optional adapters never resolve to hackney, then drop hackney frommix.exs.Preview.CDN.Fastlynow usesPreview.HTTP.post/4(a new method on the existing Finch wrapper) instead of:hackney.post/4+:hackney.body/1. Headers converted from atom-keyed keyword list to binary tuples (Finch is strict).config :ex_aws, http_client: ExAws.Request.Req— added{:req, "~> 0.5"}as a direct dep.config :sentry, client: Preview.SentryClient— new module implementingSentry.HTTPClientwith its own Finch pool (same pattern as hexdocs).{:hackney, "~> 1.20"}and{:mint, "~> 1.1"}frommix.exs(Mint stays as a Finch transitive).{:bypass, "~> 2.1", only: :test}plus a smoke test forPreview.HTTP.post.