Skip to content

Block SIGPIPE only on the OLP SDK cURL worker - #1734

Draft
khomenkd wants to merge 1 commit into
masterfrom
khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker
Draft

khomenkd wants to merge 1 commit into
masterfrom
khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker

Conversation

@khomenkd

Copy link
Copy Markdown
Contributor

Remove the library-load-time SIGPIPE mask change and block the signal when the SDK cURL worker starts. This avoids changing the application thread’s signal mask; log failures to apply the mask.

Relates-To: DATASDK-112

@khomenkd
khomenkd force-pushed the khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker branch from af448dd to 653fa9a Compare November 18, 2026 10:17
Blocking SIGPIPE at library load changes the caller's signal mask,
which can interfere with unrelated application behavior, including
writing to closed pipes.

Limit SIGPIPE blocking to the SDK cURL worker so the application
thread that loads the SDK keeps its existing signal mask.

Relates-To: DATASDK-112

Signed-off-by: Denys Khomenko <ext-denys.khomenko@here.com>
@khomenkd
khomenkd force-pushed the khomenko/Block-SIGPIPE-only-on-the-OLP-SDK-cURL-worker branch from 653fa9a to f46b3c4 Compare November 18, 2026 10:22
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.46%. Comparing base (a6c93b4) to head (f46b3c4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1734      +/-   ##
==========================================
- Coverage   80.48%   80.46%   -0.02%     
==========================================
  Files         358      358              
  Lines       14444    14443       -1     
  Branches     1582     1582              
==========================================
- Hits        11624    11621       -3     
- Misses       2179     2181       +2     
  Partials      641      641              

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant