Return NoContent if no partition found in QuadTree#1682
Open
rustam-gamidov-here wants to merge 1 commit intomasterfrom
Open
Return NoContent if no partition found in QuadTree#1682rustam-gamidov-here wants to merge 1 commit intomasterfrom
rustam-gamidov-here wants to merge 1 commit intomasterfrom
Conversation
Network and response parsing errors should be handled earlier so we have valid data and requested tile is not present. NoContent better reflects this state. Relates-To: HERESUP-50889 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1682 +/- ##
==========================================
+ Coverage 80.42% 80.42% +0.01%
==========================================
Files 351 351
Lines 14221 14221
Branches 1544 1544
==========================================
+ Hits 11436 11437 +1
+ Misses 2156 2155 -1
Partials 629 629 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Network and response parsing errors should be handled earlier so we have valid data and requested tile is not present. NoContent better reflects this state.
Relates-To: HERESUP-50889