Conversation
helsome
previously requested changes
Sep 11, 2026
helsome
left a comment
Owner
There was a problem hiding this comment.
实现与 focused tests 方向够了,不要求扩大 scope。合入前只补两点:
- 测试报告补 Bun 版本 + OS/平台;现有
run-manager.test.ts20/0、kernel 61/0、全 workspace typecheck 无需重跑扩大。 - 最新 main 已合入 #60,而 #60 同样修改
packages/shared/src/kernel/run-manager.ts/test.ts。请 rebase 最新 main,解决该真实重叠后跑基础 CI,确认 financial evidence wiring 与 wall-clock deadline 都保留。
补齐后即可继续审核;本 PR 不涉及 UI,无需截图。
Sthreal
force-pushed
the
fix/83-wall-clock-budget
branch
from
September 12, 2026 12:21
b2a53ab to
06ccc4d
Compare
Author
|
@helsome 已补齐两项:
Rebase 后验证:
已 force-with-lease 更新 PR 分支,请再次 review。 |
helsome
dismissed
their stale review
September 14, 2026 09:33
作者已补齐 Bun/OS 测试报告,并完成包含 #60 的 rebase,验证 financial evidence 与 wall-clock deadline 共存。原 review blocker 已解决。
helsome
approved these changes
Sep 14, 2026
helsome
left a comment
Owner
There was a problem hiding this comment.
wall-clock deadline 的实现与测试覆盖已经足够:首事件前静默、partial 后静默、ensureSession 竞态、重复 timer callback、旧 run timer 隔离都覆盖到了;#60 的 financial evidence wiring 也在此前 rebase 后保留。代码可批准。当前 main 已继续前进且 GitHub 显示不可直接合并,请只 rebase 最新 main,并重跑 run-manager/kernel focused tests + typecheck/basic CI。action_required 不作为质量失败。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动说明
为
RunManager增加显式的 wall-clock deadline,使wallClockMs不再依赖 runtime 产生新事件。具体包括:
RunManagerScheduler,生产环境使用setTimeout,测试使用手动 schedulerstopReason = budget_exhaustedstopDetail标明key = wallClockMs、limit 和实际使用量ensureSession期间到期后仍启动 runtime关联 Issue
Closes #83
验证
测试环境:
执行命令及结果:
已在最新
upstream/main(4eca2d1) 上完成 rebase。已确认 #60 的 structured financial evidence wiring 与本次 wall-clock deadline 修改同时保留;evidence 测试 4/4 通过。覆盖场景:
ensureSession期间 deadline 到期UI 截图(涉及 UI 时必填)
Before(适用时)
不适用。
After
不涉及 UI。
Scope / 后续
本 PR 完整关闭 #83,不包含 checkpoint、恢复协议或底层存储重构。无已知未完成项。