Skip to content

make MaxEntries flag configurable #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dealloc merged 1 commit into from
Jul 24, 2025
Merged

make MaxEntries flag configurable #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Helldivers-2-Sync/Configuration/HelldiversSyncConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,9 @@ public sealed class HelldiversSyncConfiguration
/// This is used in CI testing to validate sync works.
/// </summary>
public bool RunOnce { get; set; } = false;

/// <summary>
/// Get the maximum number of entries returned by ArrowHead from the newsfeed API.
/// </summary>
public uint NewsFeedMaxEntries { get; set; } = 2048;
}
9 changes: 7 additions & 2 deletions src/Helldivers-2-Sync/Services/ArrowHeadApiService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@ public async Task<Memory<byte>> GetWarStatus(string season, string language, Can
/// </summary>
public async Task<Memory<byte>> LoadFeed(string season, string language, CancellationToken cancellationToken)
{
var request = BuildRequest($"/api/NewsFeed/{season}", language);
// If the `NewsFeedMaxEntries` flag is not set to 0 we pass it in.
var request = options.Value.NewsFeedMaxEntries is 0
? BuildRequest($"/api/NewsFeed/{season}", language)
: BuildRequest($"/api/NewsFeed/{season}?maxEntries=${options.Value.NewsFeedMaxEntries}", language);

using var response = await http.SendAsync(request, cancellationToken);

// Throw on error responses so we don't have to look down the entire serialisation tree.
Expand Down Expand Up @@ -102,7 +106,8 @@ public async Task<Memory<byte>> LoadAssignments(string season, string language,
/// <summary>
/// Loads space station of a given <paramref name="season" /> and <paramref name="id"/> in <paramref name="language" />.
/// </summary>
public async Task<Memory<byte>> LoadSpaceStations(string season, long id, string language, CancellationToken cancellationToken)
public async Task<Memory<byte>> LoadSpaceStations(string season, long id, string language,
CancellationToken cancellationToken)
{
var request = BuildRequest($"/api/SpaceStation/{season}/{id}", language);
using var response = await http.SendAsync(request, cancellationToken);
Expand Down