Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/docker/tasks/engine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@
aliases:
host: "{{ [''] if devbox_docker_here else [] }}"
vars:
devbox_docker_found: "{{ (devbox_docker_server.stdout ~ '|').split('|') if devbox_docker_server.rc == 0 else ['', ''] }}"
devbox_docker_container: "{{ (devbox_docker_server.stdout ~ '|').split('|') if devbox_docker_server.rc == 0 else ['', ''] }}"
devbox_docker_here: >-
{{ (devbox_apply_from | default('')) | length > 0
and (devbox_apply_from | default('')) in devbox_docker_found[0].split() }}
devbox_docker_local: "{{ devbox_docker_here and '/var/run/docker.sock' in devbox_docker_found[1].split() }}"
and (devbox_apply_from | default('')) in devbox_docker_container[0].split() }}
devbox_docker_local: "{{ devbox_docker_here and '/var/run/docker.sock' in devbox_docker_container[1].split() }}"

37 changes: 37 additions & 0 deletions tests/test_task_names.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
"""A variable a task registers outranks the vars of a later task with the
same name, so a task's vars never take the name of a registered result."""
from pathlib import Path
import unittest

try:
import yaml
except ImportError:
yaml = None

ROOT = Path(__file__).resolve().parents[1]


def tasks(node):
"""Every task in a list of tasks, blocks opened."""
for task in node or []:
if not isinstance(task, dict):
continue
yield task
for key in ('block', 'rescue', 'always'):
yield from tasks(task.get(key))


@unittest.skipUnless(yaml, 'needs PyYAML: install provision/requirements.txt')
class TaskNames(unittest.TestCase):
def test_no_task_vars_take_the_name_of_a_registered_result(self):
files = list(ROOT.glob('plugins/*/tasks/*.yml')) + list(ROOT.glob('provision/ansible/roles/*/tasks/*.yml'))
self.assertTrue(files)
clashes = []
for path in files:
listed = list(tasks(yaml.safe_load(path.read_text())))
registered = {task['register'] for task in listed if 'register' in task}
for task in listed:
for name in (task.get('vars') or {}):
if name in registered:
clashes.append(f"{path.relative_to(ROOT)}: {task.get('name')}: {name}")
self.assertEqual(clashes, [])
Loading