Repository navigation
Collections of a provisioner: tables of pools, volumes and images with their items' actions - #64
Merged
Merged
Conversation
…d listed by its status
…volumes as collections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page of a provisioner listed every storage action as its own entry (twelve for Incus), and acting on a pool meant typing its name into a form. Things a provisioner holds are now collections: one row with a count on the page, a table of items, and a page per item with the actions on it, whose arguments the item's key fills.
collections(key, columns,withinfor nesting,kindsfor resources it made, andnew,itemandlistactions,remove,show). berth checks them when it loads the plugin; one that refers to a missing action, argument, kind or collection makes the provisioner unusable with the reason. Each action it names getscollectionset.statusascollections, besidevalues. No new route.nmakes one (picks among several ways),xremoves after a question that names the item,rrefreshes, Esc goes back. Unavailable item actions are greyed with their reason. The table refreshes after the job.berth provisioner showprints each collection as a table;berth provisioner actionshas a collection column. Every action still runs withberth provisioner run.Checked with cargo test, fmt, clippy, the Python tests with PyYAML, vale, and
ci/run.sh e2e e2e_provisionerswith the Docker engine.