Skip to content

Minor TODO fixes#1207

Merged
VisLab merged 4 commits intohed-standard:mainfrom
VisLab:remove_vis
Feb 6, 2026
Merged

Minor TODO fixes#1207
VisLab merged 4 commits intohed-standard:mainfrom
VisLab:remove_vis

Conversation

@VisLab
Copy link
Member

@VisLab VisLab commented Feb 5, 2026

No description provided.

@VisLab VisLab requested a review from Copilot February 5, 2026 19:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes deprecated code and modernizes Python version compatibility by replacing a custom remove_prefix utility function with Python's built-in str.removeprefix() method, and deletes unused test and implementation files.

Changes:

  • Replaced custom remove_prefix function with Python's built-in str.removeprefix() method across multiple files
  • Removed the now-unused remove_prefix function definition from df_util.py
  • Deleted unused SequenceMap class implementation and its associated test file
  • Updated the hed-examples subproject commit reference

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/tools/analysis/test_sequence_map.py Removed entire test file for unused SequenceMap functionality
spec_tests/hed-examples Updated subproject commit reference
hed/tools/analysis/sequence_map.py Removed entire SequenceMap class implementation
hed/schema/schema_io/schema2df.py Removed import and replaced remove_prefix call with removeprefix()
hed/schema/schema_io/hed_id_util.py Removed import and replaced remove_prefix calls with removeprefix(), added null check
hed/schema/schema_io/df_util.py Removed deprecated remove_prefix function definition
hed/schema/schema_attribute_validator_hed_id.py Removed import and replaced remove_prefix calls with removeprefix()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@VisLab VisLab merged commit 55fa874 into hed-standard:main Feb 6, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant