Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated code and modernizes Python version compatibility by replacing a custom remove_prefix utility function with Python's built-in str.removeprefix() method, and deletes unused test and implementation files.
Changes:
- Replaced custom
remove_prefixfunction with Python's built-instr.removeprefix()method across multiple files - Removed the now-unused
remove_prefixfunction definition fromdf_util.py - Deleted unused
SequenceMapclass implementation and its associated test file - Updated the
hed-examplessubproject commit reference
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/tools/analysis/test_sequence_map.py | Removed entire test file for unused SequenceMap functionality |
| spec_tests/hed-examples | Updated subproject commit reference |
| hed/tools/analysis/sequence_map.py | Removed entire SequenceMap class implementation |
| hed/schema/schema_io/schema2df.py | Removed import and replaced remove_prefix call with removeprefix() |
| hed/schema/schema_io/hed_id_util.py | Removed import and replaced remove_prefix calls with removeprefix(), added null check |
| hed/schema/schema_io/df_util.py | Removed deprecated remove_prefix function definition |
| hed/schema/schema_attribute_validator_hed_id.py | Removed import and replaced remove_prefix calls with removeprefix() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.