Removed the ontology-related code per issue #1177#1202
Merged
VisLab merged 1 commit intohed-standard:mainfrom Feb 4, 2026
Merged
Removed the ontology-related code per issue #1177#1202VisLab merged 1 commit intohed-standard:mainfrom
VisLab merged 1 commit intohed-standard:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes ontology/OMN generation functionality from this repository, retaining only HED ID utilities and pointing users to the separate hed-ontology repo for ontology-related operations.
Changes:
- Extracted HED ID range, assignment, and validation logic into a new
hed_id_utilmodule and updated all call sites and tests to use it. - Removed ontology-related code and tooling (
ontology_util,create_ontologyscript, CLI entry point, and related tests). - Updated documentation to remove ontology-generation steps from the release workflow and direct users to the
hed-ontologyrepository.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/schema/test_hed_id_util.py |
Redirects tests from ontology_util to the new hed_id_util module and removes tests for now-removed OMN conversion, ensuring HED ID utilities remain covered. |
pyproject.toml |
Removes the hed_create_ontology console script entry, aligning available CLI commands with the removal of ontology functionality. |
hed/scripts/hed_convert_schema.py |
Switches to hed_id_util.update_dataframes_from_schema, preserving schema update behavior while decoupling from ontology conversion. |
hed/scripts/create_ontology.py |
Deletes the ontology-creation script, fully removing ontology generation from this codebase. |
hed/schema/schema_io/ontology_util.py |
Removes the ontology/OMN conversion utilities now moved to hed-ontology, avoiding dead or duplicated functionality. |
hed/schema/schema_io/hed_id_util.py |
Introduces a focused utility module for HED ID range computation, validation, and assignment, preserving existing behavior without ontology concerns. |
hed/schema/schema_attribute_validator_hed_id.py |
Updates the get_library_data import to use hed.schema.hed_cache directly, reflecting the removal of ontology_util. |
docs/user_guide.md |
Updates schema release best-practices to drop ontology generation steps and adds a note that OMN/OWL generation is now handled in the hed-ontology repository. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.