Skip to content

Removed the visualization code#1198

Merged
VisLab merged 2 commits intohed-standard:mainfrom
VisLab:remove_vis
Feb 3, 2026
Merged

Removed the visualization code#1198
VisLab merged 2 commits intohed-standard:mainfrom
VisLab:remove_vis

Conversation

@VisLab
Copy link
Member

@VisLab VisLab commented Feb 3, 2026

No description provided.

@VisLab
Copy link
Member Author

VisLab commented Feb 3, 2026

CoPIlot review:

📊 PR Summary: Removed the visualization code

Overview

This PR removes the visualization functionality from the hed-python package by extracting it into a separate package. The change reduces dependencies and improves modularity.


🔢 Stats

  • Files changed: 9
  • Additions: +9
  • Deletions: -545
  • Net change: -536 lines

📝 Changes

Removed Files (7 files)

  1. hed/tools/visualization/__init__.py - Removed visualization module entry point
  2. hed/tools/visualization/tag_word_cloud.py (120 lines) - Word cloud generation functionality
  3. hed/tools/visualization/word_cloud_util.py (164 lines) - Word cloud support utilities and color functions
  4. tests/tools/visualization/__init__.py - Test module init
  5. tests/tools/visualization/test_tag_word_cloud.py (202 lines) - Complete test suite for word cloud
  6. tests/data/visualization/word_mask.png - Test data image

Modified Files (3 files)

Dependencies Removed:

  • pyproject.toml

    • matplotlib>=3.9.0
    • wordcloud==1.9.5
    • ✅ Updated pandas constraint: pandas>=2.2.3,<3.0.0
  • requirements.txt

    • matplotlib>=3.9.0
    • pillow>=11.2.1
    • wordcloud>=1.9.4
    • ✅ Updated pandas constraint: pandas>=2.2.3,<3.0.0

Documentation Updated:

  • README.md - Cleaned up significantly
    • ❌ Removed MyST/Sphinx index directives (````{index}` blocks throughout)
    • ✅ Added note about visualization tools moving to hed-vis package
    • ✅ Updated support links formatting
    • Note: Fixed typo in new link: www.hedtags.org/hed-resources (missing :// after https:)

💡 Suggestions

🐛 Bug to Fix

In README.md, line 303, there's a typo in the URL:

- HED documentation: [www.hedtags.org/hed-resources](https:/www.hedtags.org/hed-resources)

Should be:

- HED documentation: [www.hedtags.org/hed-resources](https://www.hedtags.org/hed-resources)

(Missing the second / in https://)

Looks Good

  1. Clean removal of visualization code with proper migration path documented
  2. Appropriate dependency cleanup
  3. Complete removal of tests along with the code
  4. Good documentation hygiene (removing Sphinx directives that weren't needed in plain markdown)

Questions to Consider

  1. Are there any imports of hed.tools.visualization elsewhere in the codebase that might break?
  2. Should there be a deprecation warning or error message if someone tries to import the old module?
  3. Is the hed-vis package already published and ready for users to migrate to?

✨ Overall Assessment

This is a clean refactoring that improves package modularity. Just fix that URL typo and you're good to go! 🚀

@VisLab VisLab merged commit 386d3af into hed-standard:main Feb 3, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant