Do not include the query string in PATH_INFO when recalling the original controller#5850
Open
augustocbx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warden sets
attempted_pathto the request's fullpath, including the query string, and the failure app was writing that value verbatim intoPATH_INFOwhen recalling the original controller. Per the Rack SPEC,PATH_INFOmust not contain a query string, and this mismatch causes valid authenticity tokens to be rejected on recall, since Rails takes the path into account when validating them.This strips the query string before mutating
PATH_INFO; the query remains available to the recalled action throughQUERY_STRING.Fixes #5704