feat(squads): adiciona MarkExMember para saída/remoção de membro - #494
Open
reag-dev wants to merge 1 commit into
Open
feat(squads): adiciona MarkExMember para saída/remoção de membro#494reag-dev wants to merge 1 commit into
reag-dev wants to merge 1 commit into
Conversation
Closes #359 ## O que muda Adiciona a Action `MarkExMember`, que registra a saída ou remoção de um membro de um squad, marcando-o como `ex_member`. ### Como funciona - Autorização via `SquadPolicy::authorize()` (capitão/vice-capitão do próprio squad, ou super-admin) - Localiza a linha ativa do subject no squad (`lockForUpdate`); sem membership ativa, lança `NotAnActiveSquadMember` - Atualiza `role => ex_member` e `left_at => now()` na mesma transação - Grava o evento `MembershipAction::Leave` na trilha de auditoria via `RecordMembershipEvent` - Como `Squad::captain()` resolve o capitão direto do pivot (`role = captain`), marcar o capitão como `ex_member` libera a vaga automaticamente, sem lógica extra ### Critérios de aceite - [x] Marcar `ex_member` seta `role=ex_member` + `left_at` + evento - [x] `ex_member` não conta na exclusividade (nenhuma checagem de exclusividade existe ainda no módulo; o estado persistido já fica correto para quando ela for implementada) - [x] Autorização via `SquadPolicy` - [x] Marcar o capitão deixa vaga (sem capitão ativo) - [x] Teste
gvieira18
approved these changes
Aug 16, 2026
5 tasks
Danilo-Sam
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materializa a Action
MarkExMember, consumindo aSquadPolicyjá registrada em CONTEXT.md, para fechar o ciclo de saída/remoção de membro do squad.handle(User $actor, Squad $squad, User $subject, ?string $reason = null): SquadMember— autoriza viaSquadPolicy::authorize()(capitão/vice-capitão do próprio squad, ou super-admin)lockForUpdate); sem membership ativa, lançaNotAnActiveSquadMemberrole => ex_membereleft_at => now()na mesma transaçãoMembershipAction::Leavena trilha de auditoria viaRecordMembershipEventSquad::captain()resolve o capitão direto do pivot (role = captain), marcar o capitão comoex_memberlibera a vaga automaticamente, sem lógica extraPlano de testes
MarkExMemberTest.php— 7 cenários (captain/sub-captain/super-admin marcam, membro comum não pode, capitão marcado libera vaga, subject sem membership ativa, subject já ex_member), 7/7 verdesapp-modules/squads— 40/40 verdesCloses #359