Repository navigation
Source OS release information from (draft) GitHub release, not pre-prod [DI-693] - #95
Merged
Merged
Conversation
JackPGreen
force-pushed
the
use-github-artifacts
branch
2 times, most recently
from
October 9, 2026 09:32
772f0b3 to
f5cfcd9
Compare
JackPGreen
marked this pull request as draft
October 9, 2026 09:43
JackPGreen
force-pushed
the
use-github-artifacts
branch
from
October 9, 2026 11:27
f5cfcd9 to
0132084
Compare
JackPGreen
force-pushed
the
use-github-artifacts
branch
from
October 9, 2026 11:31
2171c4f to
9870b86
Compare
JackPGreen
marked this pull request as ready for review
October 9, 2026 11:33
nishaatr
requested changes
Oct 13, 2026
nishaatr
left a comment
nishaatr
left a comment
Contributor
There was a problem hiding this comment.
@JackPGreen
I can test this in my next sandbox run which I will be running soon
Contributor
|
Sonar is failing with token error |
Contributor
Author
it's because it's a PR from a fork. |
nishaatr
approved these changes
Oct 13, 2026
JackPGreen
added a commit
that referenced
this pull request
Oct 15, 2026
#95 inadvertently removed a required environment variable causing [build failure](https://github.com/hz-devops-test/rel-scripts/actions/runs/38730216472/job/116405869545#step:6:53).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action expects both OS & EE artifacts to be available in the pre-prod repo during
packageto query their filesize.This is the case for EE - but not OS, where instead the artifacts are exclusively hosted on GitHub, initially in a draft GitHub release in the
hazelcastrepo, which is then published during promotion.As a result, the fails.
Updated to - in the case of OS - identify the draft-release asset URL (e.g. something like
https://github.com/hz-devops-test/hazelcast/releases/tag/untagged-625337d5ad7956e85462) and use that for artefact resolution instead.Additionally - refactored
VersionMetadataclass (that had OS+EE artefacts) to be abstract with OS/EE specific implementations.Tested locally, not in sandbox - I think easier to retest in sandbox once merged, as requires real artifacts to be built and published as a draft in the OS repo.