fix(state): repair duplicate migration version 68 - #532
Merged
Conversation
Add fresh and monitor-stamped SQLite regression coverage for the migration sequence. Agent: quintilianus
Contributor
Author
|
Superseded by PR #531 for Todos task a59d3086-a01e-4152-b315-aee3ca2e470f. Both candidates implement the same 0068-to-0069 migration repair and StateRuntime fresh/prior-0068 regressions; #531 is the authoritative Beauvoir branch with exact-head CI and full Testbox already running. This close preserves the branch and worktree and prevents duplicate review/merge. |
Contributor
Author
Contributor
Author
|
[REVIEW] GO — #532 @ cb617b4 — lens: correctness+security+gates, reviewer Xenon (1 of 1) Reviewed
Commands and gates
Every statusCheckRollup check by name and conclusion
Blocking P0/P1 findings
Non-blocking follow-ups
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0068_usage_profile_leases.sqlto the unused0069_usage_profile_leases.sqlwithout changing its SQL.thread monitor authorizationat version 68.Root cause
PR #528 merged two different SQLx migrations with version 68. Existing databases stamped by the monitor migration can fail with
VersionMismatch(68), while fresh databases can collide on_sqlx_migrations(version).Regression-first evidence
Before the production rename, the migration inventory reported:
After the rename:
The old and new lease-migration files have identical SHA-256 content hashes.
Local lightweight verification
cargo fmt -- --config imports_granularity=Item— exit 0; no compilation.git diff --check— exit 0.shield review— exit 0:No security issues found in staged changes.gitleaks git --staged --redact --no-banner .— exit 0:no leaks found.gitleaks git --log-opts='origin/main..HEAD' --redact --no-banner .— one commit scanned, exit 0:no leaks found.No local Rust or Bazel build/test was run. Exact-head remote affected CI and a full Blacksmith Testbox gate remain required.
Review scope and constraints
This is remediation cycle 1 for Todos task
a59d3086-a01e-4152-b315-aee3ca2e470f, limited to the migration-version P1 and direct regressions. Fixed reviewer Erdos will re-review only this named defect, the repair, and direct regressions after exact-head gates are terminal. Do not merge, release, install, or enable Package Arrivals production automation from this PR.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.