Open
Conversation
phadej
reviewed
Jul 31, 2025
phadej
requested changes
Jul 31, 2025
Collaborator
phadej
left a comment
phadej
left a comment
There was a problem hiding this comment.
I would like to see test added
Author
I added in 85747d2 , hopefully all good |
exaexa
commented
Aug 1, 2025
| ntuples r3 >>= assertEqual "singlerow 3" 1 | ||
| Just r4 <- getResult conn | ||
| ntuples r4 >>= assertEqual "singlerow eof" 0 | ||
| getResult conn >>= assertEqual "singlerow end" Nothing |
Author
There was a problem hiding this comment.
I decided to be a bit more verbose here (e.g. the shouldReturn use above unfortunately squishes the info about failed tests to a single line of code and single test name, this allows better debugging).
I can minify the getResult cascade code to a single zipWithM if required.
Author
|
@phadej mild bump here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
essentially this is exposing the other function from the two here https://www.postgresql.org/docs/current/libpq-single-row-mode.html , which enable row streaming for looong queries.
The PR is quite straightforward so I'm not sure if much commentary is needed. I hope the C type mapping is OK. The wider context is that we'd really like to have it for continuing the work on valderman/selda#200 .
Thanks!
-mk
(cc @benjaminweb)